Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug of import url_to_fs from fsspec (#507) #512

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fixed bug of import url_to_fs from fsspec (#507) #512

merged 3 commits into from
Jan 24, 2025

Conversation

LoserCheems
Copy link
Contributor

Fixed #507
Update to import url_to_fs from fsspec.core.

from fsspec.core import url_to_fs

It should now work.

[2025-01-24 12:57:59,214] [    INFO]: PyTorch version 2.4.1+cpu available. (config.py:54)
[2025-01-24 12:58:23,232] [    INFO]: Test gather tensor (parallelism.py:133)
[2025-01-24 12:58:23,234] [    INFO]: gathered_tensor tensor([0]), should be [0] (parallelism.py:136)
[2025-01-24 12:58:23,234] [    INFO]: --- LOADING MODEL --- (pipeline.py:168)
[2025-01-24 12:58:24,585] [    INFO]: Tokenizer truncation and padding size set to the left side. (transformers_model.py:539)
[2025-01-24 12:58:24,586] [    INFO]: We are not in a distributed setting. Setting model_parallel to False. (transformers_model.py:394)
[2025-01-24 12:58:24,586] [    INFO]: Model parallel was set to False, max memory set to None and device map to None (transformers_model.py:423) 
[2025-01-24 12:58:26,047] [    INFO]: Using Data Parallelism, putting model on device cpu (transformers_model.py:275)
[2025-01-24 12:58:26,352] [    INFO]: --- LOADING TASKS --- (pipeline.py:195)

@clefourrier
Copy link
Member

Hi!
Thanks a lot for the fix! I added a try catch as this depends on the fsspec version, can you check if it still works for you?

@hynky1999
Copy link
Collaborator

🤗 Yeah this is due to version missmatch, pinning version would be the best instead of the try imports

@clefourrier
Copy link
Member

I think we had some compat issues when pinning this one - let's go for a try catch for now and consider pinning if we absolutely need to in the future

@clefourrier clefourrier merged commit 4f381b3 into huggingface:main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clefourrier clefourrier clefourrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'url_to_fs' from 'fsspec'
3 participants
@LoserCheems @clefourrier @hynky1999